Add minify to SWPrecacheWebpackPlugin config / fix readme typos / add more instructions #2
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldhand
changed the title
Closed
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this is in the production webpack config and webpack is configured to minify/uglify everything else, I think minifying/uglyfying the generated service worker would be a nice option.
I also moved the import statement up near where the other plugin imports are and fixed a typo in the README
Merged typo fixes from #3 here.
Added instructions for testing offline-first locally (if they need to do that, its kind of fun and for some reason a lot of issues in sw-precache-webpack-plugin involve testing locally).