ensure cleanup if unmount occurs before loading finishes #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We keep track of loading state so that when loading finishes, we can properly clean up if we need to.
jeffreylanters
approved these changes
Jul 23, 2021
|
Hi Josani. Thank you so much for your contribution. I'll run some tests and merge it once I'm at my Mac later today or tomorrow. I'll let you know, have a great weekend! |
|
Thanks again! I've published you changes in version 8.4.4. |
|
@jeffreylanters in your latest (8.4.5) I think you've switched up the order of the setUnityContext and isMounted check. I think those need to reversed, because the quitUnity call won't fire if unity context isn't set... |
|
You're right, thanks for noticing man! I've merged your fix right away in the latest release. 💪🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep track of loading state so that when loading finishes, we can
properly clean up if we need to.