Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update webGLContextAttributes powerPreference type #545

Merged

Conversation

forforfos
Copy link
Contributor

This PR is an addition to #543

It updates the Type of the powerPreference attribute from the unityConfig object webglContextAttributes.

This attribute accepts the values of 0, 1 and 2 instead of 'default', 'low-power' and 'high-performance'.

@forforfos forforfos force-pushed the update_powerPerformance_types branch from bfadc3b to d569d01 Compare February 29, 2024 13:05
@forforfos forforfos closed this Feb 29, 2024
@forforfos forforfos reopened this Feb 29, 2024
@forforfos
Copy link
Contributor Author

@jeffreylanters
Hello!
I was wondering if there is something missing so as to merge this PR.

@jeffreylanters
Copy link
Owner

Excuse me @forforfos, I've had a lot going on privately, so release the PR was delayed a bit. I'll merge and release it this week. Thanks for checking with me! 🙌🏼

@jeffreylanters jeffreylanters merged commit 2c6cae8 into jeffreylanters:main Mar 12, 2024
@jeffreylanters
Copy link
Owner

Released in https://github.com/jeffreylanters/react-unity-webgl/releases/tag/v9.5.1

Thanks for your contribution!

@forforfos
Copy link
Contributor Author

Excuse me @forforfos, I've had a lot going on privately, so release the PR was delayed a bit. I'll merge and release it this week. Thanks for checking with me! 🙌🏼

No worries friend! I was just wondering if I was missing something to complete the PR!

Thank you very much for your time and feedback! <3

On a separate matter, if you have time, check this out at some point! #544 I would really like to implement it, and it is really fast and easy I think!

kisses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants