Implement thread local storage for linux

[jeffreytan81]

No description provided.

[github-actions]

⚠️ Python code formatter, darker found issues in your code. ⚠️

You can test this locally with the following command:

darker --check --diff -r 5f17fcf3010a8393658d38b41a73c9ef8e06bf6d..b8093c5ae5c718e8badc4cbd378aba84d34b1bb1 lldb/test/API/lang/c/tls_globals/TestTlsGlobals.py

View the diff from darker here.

--- TestTlsGlobals.py	2023-09-26 16:23:37.000000 +0000
+++ TestTlsGlobals.py	2023-09-26 16:29:12.089398 +0000
@@ -36,13 +36,11 @@
             )
 
     # TLS works differently on Windows, this would need to be implemented
     # separately.
     @skipIfWindows
-    @skipIf(
-        oslist=no_match([lldbplatformutil.getDarwinOSTriples(), "linux"])
-    )
+    @skipIf(oslist=no_match([lldbplatformutil.getDarwinOSTriples(), "linux"]))
     def test(self):
         """Test thread-local storage."""
         self.build()
         exe = self.getBuildArtifact("a.out")
         target = self.dbg.CreateTarget(exe)

[github-actions]

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:

git-clang-format --diff 5f17fcf3010a8393658d38b41a73c9ef8e06bf6d b8093c5ae5c718e8badc4cbd378aba84d34b1bb1 -- lldb/include/lldb/Target/RegisterContext.h lldb/include/lldb/lldb-defines.h lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp lldb/source/Plugins/Process/Utility/RegisterInfos_x86_64_with_base.h lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp lldb/source/Target/RegisterContext.cpp lldb/source/Target/Thread.cpp lldb/source/Utility/Args.cpp

View the diff from clang-format here.

diff --git a/lldb/include/lldb/lldb-defines.h b/lldb/include/lldb/lldb-defines.h
index f3f316fef..aaf0b04e4 100644
--- a/lldb/include/lldb/lldb-defines.h
+++ b/lldb/include/lldb/lldb-defines.h
@@ -71,7 +71,7 @@
   11 // The register that would contain pointer size or less argument 7 (if any)
 #define LLDB_REGNUM_GENERIC_ARG8                                               \
   12 // The register that would contain pointer size or less argument 8 (if any)
-#define LLDB_REGNUM_GENERIC_TP 13    // Thread pointer
+#define LLDB_REGNUM_GENERIC_TP 13 // Thread pointer
 /// Invalid value definitions
 #define LLDB_INVALID_STOP_ID 0
 #define LLDB_INVALID_ADDRESS UINT64_MAX
diff --git a/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp b/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp
index 51ce263ad..cb174d31b 100644
--- a/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp
+++ b/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp
@@ -715,7 +715,8 @@ bool DYLDRendezvous::FindMetadata(const char *name, PThreadField field,
   Address address = list[0].symbol->GetAddress();
   address.SetOffset(address.GetOffset() + field * sizeof(uint32_t));
   Status error;
-  value = target.ReadUnsignedIntegerFromMemory(address, sizeof(uint32_t), 0, error);
+  value =
+      target.ReadUnsignedIntegerFromMemory(address, sizeof(uint32_t), 0, error);
   if (error.Fail())
     return false;