Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes for bones and fingers addition. #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wouterpotters
Copy link

For some reason finger_type mixes with the bone position in the matlab struct --> disabled finger_type.
Fixes indices of bone properties

@jeffsp
Copy link
Owner

jeffsp commented May 24, 2017

Hi @wouterpotters,

Thanks for the bug fix!

Could you please check your merge request at https://github.com/jeffsp/matleap/pull/18/files and replace tabs with four char spaces and remove trailing newlines? I know it seems trivial, but spurious whitespace makes it difficult to see the changes, and tabs break the formatting.

Thanks,
Jeff

Copy link
Owner

@jeffsp jeffsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wouterpotters,

Thanks for the bug fix!

Could you please check your merge request at https://github.com/jeffsp/matleap/pull/18/files and replace tabs with four char spaces and remove trailing newlines? I know it seems trivial, but spurious whitespace makes it difficult to see the changes, and tabs break the formatting.

Thanks,
Jeff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants