Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PostgreSQL and other databases #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

carlosonunez
Copy link

While I was completing this challenge, I made the mistake of thinking before
looking at this codebase that I could use any database.

I chose PostgreSQL out of familiarity. I chose poorly.

I wasn't sure whether modifying my infrastructure code to use Mongo would be
faster than just shimming in Postgres support into this codebase, so I went wit
the latter because it was more fun.

This pull request adds support for persisting Tasky to-dos into PostgreSQL. It
also decouples the persistence layer through a simple interface so that others
can add support for more databases, like SQLite or MySQL.

I hope this helps!

Signed-off-by: Carlos Nunez <13461447+carlosonunez@users.noreply.github.com>
Signed-off-by: Carlos Nunez <13461447+carlosonunez@users.noreply.github.com>
Signed-off-by: Carlos Nunez <13461447+carlosonunez@users.noreply.github.com>
Signed-off-by: Carlos Nunez <13461447+carlosonunez@users.noreply.github.com>
@jeffthorne
Copy link
Owner

Thanks Carlos 👍 Will Review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants