[feature]: initial attempt at caching songs #337
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough draft of supporting caching songs.
Notes:
feishin-cache
protocol can be avoided entirely by disabling web security (allowing loadingfile://
URLs). I'd rather not force this. It should be safe from directory traversal attempts, but not confident there...application/octet-stream
. Somehow this still appears to work for web player (MPV is completely fine it seems)TODO:
file://
? Probably.<input>
would also work herefetch
can in fact get the entire file (when done properly?). Would also want to request persistent storage, so the quotas could be much higher.