Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lyrics Translation and Romaji (Fulfill #732) [Translation Part] #747

Merged
merged 25 commits into from
Sep 24, 2024
Merged

Lyrics Translation and Romaji (Fulfill #732) [Translation Part] #747

merged 25 commits into from
Sep 24, 2024

Conversation

ENDlezZenith
Copy link
Contributor

@ENDlezZenith ENDlezZenith commented Sep 16, 2024 •
edited
Loading

Fulfill #732:

  • Lyrics Translation
    • Microsoft Azure Translator API for Initial Support (2M Chars Free per Month + Pay as You Go)
    • Google Cloud Translation API for Wider Range of Users (0.5M Chars Free per Month + Pay as You Go)
  • Lyrics Romaji (TOO MANY ISSUES, POSTPONED, SPLIT PR)
    • Try Kuroshiro Library from Forks which at Least has Initial TypeScript Support

@ENDlezZenith
modified: package.json
08a9624 
	modified:   src/i18n/locales/en.json
	modified:   src/renderer/features/lyrics/lyrics-actions.tsx
	modified:   src/renderer/features/lyrics/lyrics.tsx
	modified:   src/renderer/features/player/components/visualizer.tsx
@ENDlezZenith
Lyrics Translation Settings Init and Typo Revert
f63dc01
@ENDlezZenith
Merge branch 'jeffvli:development' into development
6334920
@ENDlezZenith
Lib Type Add and Default Value
a0f1d56
@ENDlezZenith
Merge branch 'development' of https://github.com/DrENDzZ/feishin into…
9135c3a 
… development
@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
feishin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 7:45am

@ENDlezZenith
Copy link
Contributor Author

ENDlezZenith commented Sep 19, 2024 •
edited
Loading

Getting a bunch of "Not rewriting GET /@sglkc/kuromoji/dict/filename.gz because the path includes a dot (.) character." in my dev env. I have no idea on fixing this. :(

@ENDlezZenith
Copy link
Contributor Author

ENDlezZenith commented Sep 19, 2024 •
edited
Loading

Getting a bunch of "Not rewriting GET /@sglkc/kuromoji/dict/filename.gz because the path includes a dot (.) character." in my dev env. I have no idea on fixing this. :(

This is fixed by adding disableDotRule: true in webpack dev server config, but again we got another error. It's like solving an error and getting another one in its dependency, and on, and on in the Romaji Part. I'm thinking of splitting this PR into two halves regarding that the translation part is almost done.

@ENDlezZenith ENDlezZenith changed the title Lyrics Translation and Romaji Lyrics Translation and Romaji [Translation Part] Sep 20, 2024
@ENDlezZenith ENDlezZenith marked this pull request as ready for review September 20, 2024 11:38
@ENDlezZenith ENDlezZenith changed the title Lyrics Translation and Romaji [Translation Part] Lyrics Translation and Romaji (Fulfill #732) [Translation Part] Sep 20, 2024
@jeffvli jeffvli linked an issue Sep 24, 2024 that may be closed by this pull request
Lyrics Translation and Romaji (Phonetic symbol for Japanese songs) #732
Closed
1 task
@jeffvli jeffvli merged commit 31492fa into jeffvli:development Sep 24, 2024
2 checks passed
@jeffvli jeffvli mentioned this pull request Oct 16, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffvli jeffvli jeffvli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lyrics Translation and Romaji (Phonetic symbol for Japanese songs)
2 participants
@ENDlezZenith @jeffvli