New graph screen #169
New graph screen #169
Conversation
Still very dirty but filtered data from selected view is now available (has been printed) not yet put into graphDisplay process though
…ier to just do it again here
…s there are no other functions other than graphing
…ed as the one in entriesdisplay
| "usecurrentviewlist" => $screen->getVar('usecurrentviewlist') | ||
| ); | ||
| include_once XOOPS_ROOT_PATH."/modules/formulize/include/graphdisplay.php"; | ||
| displayGraph('Bar', $screen->getVar('fid'), $screen->getVar('frid'), $screen->getVar('labelelem'), $screen->getVar('dataelem'), $screen->getVar('ops'), $options); |
There was a problem hiding this comment.
There's a problem here. These two variables are integers, which represent element IDs: $screen->getVar('labelelem'), $screen->getVar('dataelem'). Later in graphdislay.php, these are used like this: display($entry, $dataElement);. It works if the element has the same ID and handle, but if the element handle has been changed to text, such as, 'client_name' then it fails. The code in one of these places should be changed so that it's consistently using element IDs or handles, and it's probably better to use handles since that's what a lot of the other code does.
|
at the beginning, all graphs are stored with label element id and data element id. And later it should be using element id any where else. I didn't notice this before. should I change all to handles? that means change from very beginning. or i just fix this by using id in other places? I found the original display function there. It is using handles every where. how about i wrote a function that can convert ids and handles then call display only for graph screen. Fixing this from beginning will take longer time. I would prefer fixing this from beginning, but is it worth to spend a lot of time to fix it rather than a small function doing the converting stuff? I think at the beginning they were using element ids for graph screen. and when it comes to display function they didn't notice this difference too. |
In graphdisplay.php, using element handle instand of element id. in graphScreen.php, convert element id to element handle before calling dispalyGraph
|
so far i have changed a lot in graphdisplay.php. now we will process all data then according to the graph type to generate the graph. still need some small improvements |
Added a field to show what is the type of graph screen A link can go back to screen lists
…ds - set label field same as data if default is selected, remove option to have no data selection
No description provided.