Implemented dynamic editing UI for admin page with slidepanel #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $xoopsTpl->assign('scrollx', intval($_POST['scrollx'])); | ||
| $accordion_active = (isset($_POST['accordion_active']) AND $_POST['accordion_active'] !== "" AND $_POST['accordion_active'] !== "false") ? intval($_POST['accordion_active']) : "false"; | ||
| $xoopsTpl->assign('accordion_active', $accordion_active); | ||
| $xoopsTpl->display("db:admin/ui.html"); |
There was a problem hiding this comment.
I believe this is where it dynamically generates the markup from php.
Then within the markup it directs the save.php at formulize/ instead of /admin
| @@ -182,7 +182,7 @@ | |||
|
|
|||
| function sendFormData(thisformdata, ele_id) { | |||
| if(!ele_id) { ele_id = 0 } | |||
| $.post("save.php?ele_id="+ele_id, $(thisformdata).serialize(), function(data) { | |||
| $.post("<{$xoops_url}>/save.php?ele_id="+ele_id, $(thisformdata).serialize(), function(data) { | |||
There was a problem hiding this comment.
After changing this line, when re-testing on browser, it continues to generate the following page source:
function sendFormData(thisformdata, ele_id) {
if(!ele_id) { ele_id = 0 }
-already cleared all cache, but still persists.
| } else { | ||
| $col_one = "<p id=\"subform-caption-f$fid-sf$subform_id\" class=\"subform-caption\"><b>" . trans($customCaption) . "</b></p>"; // <p style=\"font-weight: normal;\">" . _formulize_ADD_HELP; |
There was a problem hiding this comment.
The id attribute was recently added here, and it shouldn't be removed.
|
The tree control looks good! |
Conflicts: modules/formulize/include/formdisplay.php modules/formulize/templates/css/style.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently investigating on the save function in the slidepanel.
When the slidepanel successfully renders, the "save your changes" button changes it's direction instead of admin/save.php, it points to formulize/save.php
Couple notes:
*** As soon as the major issues are dealt with, I will re-organize the plugin paths again