-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the corner cases #173
Fix the corner cases #173
Conversation
@sueka Thanks for the PR! If you can fix |
This reverts commit 02b98d8.
Fixed it. I think there are two ways to fix the |
This looks pretty good. Can you perhaps add a couple of test cases that would have previously caused zero division & zero vector normalization errors but are handled now? I hate to keep throwing up barriers, but this is a tricky section of code, so I want to make sure we don't have a regression here. |
I've added tests against zero vector normalization and zero division errors. |
Awesome, thanks again for the great contribution! |
I've tried doing
0.0 / 0.0
)