Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HTML entities to prevent Liquid from processing this info #172

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Use HTML entities to prevent Liquid from processing this info #172

merged 1 commit into from
Oct 2, 2019

Conversation

parkr
Copy link
Member

@parkr parkr commented Oct 1, 2019

No description provided.

@ashmaroli
Copy link
Member

Guys, IMO the cleaner approach would be to use Liquid's raw tags instead. The primary reason being the massive hit that readability via GitHub interface took:
github com_jekyll_github-metadata_blob_c35f1192f8d410fb033a90c0ed37248e7efd2275_docs_site github md

@DirtyF
Copy link
Member

DirtyF commented Oct 2, 2019 •
edited
Loading

You have to insert HTML comments to prevent raw tags from showing up on GitHub, we do that on some docs.

DirtyF
DirtyF reviewed Oct 2, 2019
View reviewed changes
docs/site.github.md Outdated Show resolved Hide resolved
@parkr @DirtyF
Add {% raw %} block inside HTML comments to prevent example from bein…
017b483 
…g processed

Co-authored-by: Frank Taillandier <frank@taillandier.me>
@parkr parkr merged commit 46db5d7 into master Oct 2, 2019
@parkr parkr deleted the html-entities-for-raw branch October 2, 2019 15:37
@jekyll jekyll locked and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF left review comments

@benbalter benbalter benbalter approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@parkr @ashmaroli @DirtyF @benbalter @jekyllbot