Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gemspec dependency on Jekyll #34

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Remove gemspec dependency on Jekyll #34

merged 2 commits into from
Oct 7, 2019

Conversation

ashmaroli
Copy link
Member

So that it can be bundled with Jekyll directly

@ashmaroli
Remove gemspec dependency on Jekyll
208c8d1 
So that it can be bundled with Jekyll directly
@ashmaroli ashmaroli mentioned this pull request Aug 15, 2019
Closed
@pathawks
Copy link
Member

Instead of removing this, perhaps we should make it a dev dependency; I'm not sure the tests will run without Jekyll.

@ashmaroli
Copy link
Member Author

should make it a dev dependency

Ah! That's a nice suggestion. 👍
Especially since CI would not have caught that lapse as they receive lateral support from the Gemfile and ENV.

@DirtyF DirtyF marked this pull request as ready for review September 30, 2019 19:16
@DirtyF
Copy link
Member

DirtyF commented Oct 7, 2019

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 484bb5a into jekyll:master Oct 7, 2019
jekyllbot added a commit that referenced this pull request Oct 7, 2019
@jekyllbot
Update history to reflect merge of #34 [ci skip]
bb96c49
@ashmaroli ashmaroli deleted the remove-jekyll-dependency branch March 2, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathawks pathawks pathawks approved these changes

Assignees
No one assigned
Labels
fix internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashmaroli @pathawks @DirtyF @jekyllbot