Fix mangling of whitespace when site.lang is set
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +32,7 @@ def source_path | |||
|
|
|||
| def feed_content | |||
| feed = PageWithoutAFile.new(@site, File.dirname(__FILE__), "", path) | |||
| feed.content = File.read(source_path).gsub(/\s+([{<])/, '\1') | |||
| feed.content = File.read(source_path).gsub(/(?<!\")\s+([<{])/, '\1') | |||
There was a problem hiding this comment.
Would it have also worked to put the space on the other side of the hreflang, i.e. at the beginning (right after {% if %}) instead of at the end?
There was a problem hiding this comment.
There's no way we can remember to always do that going forward, nor could we expect contributors to deal with an odd behavior like that.
|
YOU'RE A HERO thank you @jekyllbot: merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which slams
hreflanginto the preceding attribute, causing parse errors.This just adds a quick negative look behind to change the whitespace stripping behavior.