Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smartify filter #117

Merged
merged 1 commit into from
Jul 8, 2016
Merged

Use smartify filter #117

merged 1 commit into from
Jul 8, 2016

Conversation

pathawks
Copy link
Member

Requires Jekyll 3.1

Processes most strings with SmartyPants to replace characters with their fancy typographic equivalent.

@benbalter
Copy link
Contributor

What's the value of using Smartypants here? Aren't we actually XML escaping, since we're generating XML?

@pathawks
Copy link
Member Author

If there is a title like Pat's Blog, the smartify filter will substitute a real apostrophe and escape, so the output is Pat‘s Blog

@benbalter
Copy link
Contributor

Nice. 👍. Also double checked, per https://validator.w3.org/feed/docs/atom.html, that HTML entities are allowed for plain text fields.

@pathawks
Copy link
Member Author

I was wrong, smartify does not escape it's output. So with input Pat's Blog, it will output Pat’s Blog.

With this in mind, we probably want to keep xml_escape in there?

@@ -112,12 +112,16 @@ There are several ways to convey author-specific information. Author information
author: benbalter
```

* `image` - URL of an image that is representative of the post.
* `image` - URL of an image that is representative of the post.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the noise. My text editor strips trailing space on save 😕

@pathawks
Copy link
Member Author

pathawks commented Jul 8, 2016

@jekyllbot: merge

@jekyllbot jekyllbot merged commit 132b5e8 into master Jul 8, 2016
@jekyllbot jekyllbot deleted the pr/smartify branch July 8, 2016 18:24
jekyllbot added a commit that referenced this pull request Jul 8, 2016
@jekyll jekyll locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants