Simplify minify regular expression #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbalter
approved these changes
Oct 15, 2016
|
I see a |
Not a bad idea, but the trick is that is kind of has to be a context aware minify. It is easy to minify these templates before they are rendered because we know that there is nowhere in the template where whitespace is significant. Once we start dealing with user generated content, we never know when we might run into a |
|
@jekyllbot: merge +dev |
pathawks
commented
Oct 15, 2016
| # 1. A '>', which closes an XML tag or | ||
| # 2. A '}', which closes a Liquid tag | ||
| # We will strip all of this whitespace to minify the template | ||
| MINIFY_REGEX = %r!(?<=>|})\s+! |
There was a problem hiding this comment.
This could be changed to %r!(?<=[>}])\s+!
I don't know if that would be any better or worse 🐳
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.