Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed entries must contain <author> #152

Merged
merged 2 commits into from
Jan 15, 2017
Merged

Feed entries must contain <author> #152

merged 2 commits into from
Jan 15, 2017

Conversation

pathawks
Copy link
Member

@pathawks pathawks commented Jan 5, 2017

If no author is set, this will output <author><name></name></author>.

Feed validator will recommend not having a blank name, but this will validate where previously it would not, because <author> is a required child of <entry>

Fixes #146

/cc: @dret @zixia

@pathawks pathawks added the fix label Jan 5, 2017
Copy link
Member Author

@pathawks pathawks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I changed the indentation, it looks like I've changed more that what I actually did. 😕

@pathawks pathawks added this to the v1.0.0 milestone Jan 5, 2017
@pathawks
Copy link
Member Author

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit e5c1256 into master Jan 15, 2017
@jekyllbot jekyllbot deleted the pull/default-author branch January 15, 2017 18:57
jekyllbot added a commit that referenced this pull request Jan 15, 2017
@jekyll jekyll locked and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feeds must contain <author> to validate
3 participants