Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing slash from feed ID #159

Merged
merged 2 commits into from
Feb 16, 2017
Merged

Remove trailing slash from feed ID #159

merged 2 commits into from
Feb 16, 2017

Conversation

pathawks
Copy link
Member

See #158

@pathawks pathawks changed the title Failing test: URL contains trailing slash Remove trailing slash from feed ID Feb 16, 2017
@pathawks
Copy link
Member Author

Rubocop error is unrelated

@benbalter
Copy link
Contributor

@jekyllbot: merge +minor.

@jekyllbot jekyllbot merged commit 18b8507 into master Feb 16, 2017
@jekyllbot jekyllbot deleted the pr/double-slash branch February 16, 2017 20:12
jekyllbot added a commit that referenced this pull request Feb 16, 2017
@jekyllbot
Update history to reflect merge of #159 [ci skip]
f5fc6cf
@benbalter
Copy link
Contributor

Nice catch @pathawks! 🌷 🐢 🌮

@benbalter
Copy link
Contributor

Think it's worth releasing a 0.9.0? ~35 commits on master.

@pathawks
Copy link
Member Author

I think @ashmaroli and I noticed it at the exact same moment.

I think it would be fine to release a 0.9.0

We should mention somewhere that all feed IDs will change now. That may result in previously read items appearing as unread in feed readers. Nothing that can be done to prevent that, however.

@ashmaroli
Copy link
Member

or how about a v1.0? esp. with the namespace change n all.. Jekyll::JekyllFeed is JekyllFeed::Generator now.. Doesn't that qualify as a major change in API?
Please enlighten me.

Moreover, I thought removing / was just a bug-fix, but apparently its a Minor Enhancement. This became clear by reading Pat's comment above though..

@pathawks
Copy link
Member Author

Public API is not considered stable until 1.0.0. According to semver.org:

Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.

We are still in the initial development stage. We will ship 1.0.0 when things are stable. We are close.

@ashmaroli
Copy link
Member

Okay. Thanks 😃

@jekyll jekyll locked and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@benbalter benbalter benbalter approved these changes

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pathawks @benbalter @ashmaroli @DirtyF @jekyllbot