-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Categories and collections #228
Changes from 5 commits
af6272f
cd2a296
57bc99a
88fb65f
e40aa53
2659efa
64ee9dc
44bee9a
383d259
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,8 +8,14 @@ class Generator < Jekyll::Generator | |
# Main plugin action, called by Jekyll-core | ||
def generate(site) | ||
@site = site | ||
return if file_exists?(feed_path) | ||
@site.pages << content_for_file(feed_path, feed_source_path) | ||
collections.each do |name, meta| | ||
Jekyll.logger.info "Jekyll Feed:", "Generating feed for #{name}" | ||
(meta["categories"] + [nil]).each do |category| | ||
ashmaroli marked this conversation as resolved.
Show resolved
Hide resolved
|
||
path = feed_path(:collection => name, :category => category) | ||
next if file_exists?(path) | ||
@site.pages << make_page(path, :collection => name, :category => category) | ||
end | ||
end | ||
end | ||
|
||
private | ||
|
@@ -20,18 +26,59 @@ def generate(site) | |
# We will strip all of this whitespace to minify the template | ||
MINIFY_REGEX = %r!(?<=>|})\s+! | ||
|
||
# Path to feed from config, or feed.xml for default | ||
def feed_path | ||
if @site.config["feed"] && @site.config["feed"]["path"] | ||
@site.config["feed"]["path"] | ||
# Returns the plugin's config or an empty hash if not set | ||
def config | ||
@site.config["feed"] || {} | ||
end | ||
|
||
# Determines the destination path of a given feed | ||
# | ||
# collection - the name of a collection, e.g., "posts" | ||
# category - a category within that collection, e.g., "news" | ||
# | ||
# Will return "feed.xml", or the config-specified default feed for posts | ||
# Will return `/feed/category.xml` for post categories | ||
# WIll return `/feed/collection.xml` for other collections | ||
# Will return `/feed/collection/category.xml` for other collection categories | ||
def feed_path(collection: "posts", category: nil) | ||
prefix = collection == "posts" ? "/feed" : "feed/#{collection}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is there a leading slash for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch. That is an oversight. Will push up a fix. |
||
if category | ||
"#{prefix}/#{category}.xml" | ||
elsif collections[collection]["path"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should do nil checking here in case |
||
collections[collection]["path"] | ||
else | ||
"feed.xml" | ||
"#{prefix}.xml" | ||
end | ||
end | ||
|
||
# Returns a hash representing all collections to be processed and their metadata | ||
# in the form of { collection_name => { categories = [...], path = "..." } } | ||
def collections | ||
return @collections if defined?(@collections) | ||
|
||
@collections = if config["collections"].is_a?(Array) | ||
config["collections"].map { |c| [c, {}] }.to_h | ||
elsif config["collections"].is_a?(Hash) | ||
config["collections"] | ||
else | ||
{} | ||
end | ||
|
||
@collections = normalize_posts_meta(@collections) | ||
@collections.each do |_name, meta| | ||
meta["categories"] = (meta["categories"] || []).to_set | ||
end | ||
|
||
@collections | ||
end | ||
|
||
# Path to feed.xml template file | ||
def feed_source_path | ||
File.expand_path "feed.xml", __dir__ | ||
@feed_source_path ||= File.expand_path "feed.xml", __dir__ | ||
end | ||
|
||
def feed_template | ||
@feed_template ||= File.read(feed_source_path).gsub(MINIFY_REGEX, "") | ||
end | ||
|
||
# Checks if a file already exists in the site source | ||
|
@@ -44,14 +91,29 @@ def file_exists?(file_path) | |
end | ||
|
||
# Generates contents for a file | ||
def content_for_file(file_path, file_source_path) | ||
|
||
def make_page(file_path, collection: "posts", category: nil) | ||
file = PageWithoutAFile.new(@site, __dir__, "", file_path) | ||
file.content = File.read(file_source_path).gsub(MINIFY_REGEX, "") | ||
file.data["layout"] = nil | ||
file.data["sitemap"] = false | ||
file.data["xsl"] = file_exists?("feed.xslt.xml") | ||
file.content = feed_template | ||
file.data.merge!({ | ||
"layout" => nil, | ||
"sitemap" => false, | ||
"xsl" => file_exists?("feed.xslt.xml"), | ||
"collection" => collection, | ||
"category" => category, | ||
}) | ||
file.output | ||
file | ||
end | ||
|
||
# Special case the "posts" collection, which, for ease of use and backwards | ||
# compatability, can be configured via top-level keys or directly as a collection | ||
def normalize_posts_meta(hash) | ||
hash["posts"] ||= {} | ||
hash["posts"]["path"] ||= config["path"] | ||
hash["posts"]["categories"] ||= config["categories"] | ||
config["path"] ||= hash["posts"]["path"] | ||
hash | ||
end | ||
end | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
--- | ||
--- | ||
|
||
Look at me! I'm a collection! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
category: news | ||
--- | ||
|
||
Look at me! I'm a collection doc in a category! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
--- | ||
excerpt: "Foo" | ||
image: "/image.png" | ||
category: news | ||
--- | ||
|
||
# December the twelfth, actually. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
--- | ||
image: https://cdn.example.org/absolute.png?h=188&w=250 | ||
category: news | ||
--- | ||
|
||
March the second! |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ tags: | |
- '"/><VADER>' | ||
image: | ||
path: "/object-image.png" | ||
category: updates | ||
--- | ||
|
||
March the fourth! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO
..will be output to
reads better..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or active voice: "The default output-path for collection feeds is
/feed/<COLLECTION>.xml
"