-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby 3.0 to CI #337
Add Ruby 3.0 to CI #337
Conversation
Both Travis and AppVeyor are in use. The reason for this is unclear for me. I updated only Travis, because it had newer versions of everything. Should also AppVeyor be updated? |
Oh, build for Ruby 3.0 failed due to missing |
@oturpe yes the plan is to move all our CI to GitHub Actions, but we still need to test 3.9 and 4.2 |
jekyll-feed will be [included in Fedora 34][pkg] which will also use [Ruby 3.0 as system Ruby interpreter][ruby]. This combination is known to work, so it would make sense to add it to CI. In Ruby 3.0, `rss` moved from default gem to a bundled gem, thus it must be added as dependency when it is used. [pkg]: https://src.fedoraproject.org/rpms/rubygem-jekyll-feed [ruby]: https://fedoraproject.org/wiki/Changes/Ruby_3.0
Rss gem fix added. Very common problem in Ruby 3.0 migration, because there was no warning in Ruby 2.7. Luckily, easy to fix too. You can either merge this pull request, or just take the good parts if that fits the plan better. |
The solution for the |
Thank you @oturpe |
jekyll-feed will be included in Fedora 34 which will also use Ruby 3.0
as system Ruby interpreter. This combination is known to work, so it
would make sense to add it to CI.