Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uri in all places #45

Merged
merged 2 commits into from
May 25, 2015
Merged

Use uri in all places #45

merged 2 commits into from
May 25, 2015

Conversation

benbalter
Copy link
Contributor

For site.author we used uri, but for post.author we used url. I personally like url better, it's less pretentious, but went with uri in all cases, to match the documentation.

@benbalter benbalter self-assigned this May 22, 2015
@pathawks
Copy link
Member

The test is wrong; should be updated to look for /<author>\s*<name>Ben</name>\s*<email>ben@example.com</email>\s*<uri>http://ben.balter.com</uri>\s*</author>/

@benbalter
Copy link
Contributor Author

Good catch. Tests now pass.

benbalter added a commit that referenced this pull request May 25, 2015
@benbalter
Merge pull request #45 from jekyll/url-uri
7c83620 
Use uri in all places
@benbalter benbalter merged commit 7c83620 into master May 25, 2015
@benbalter benbalter deleted the url-uri branch May 25, 2015 19:16
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@benbalter benbalter

Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbalter @pathawks @jekyllbot