Loosen Jekyll Version Requirements. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @benbalter @parkr @jekyll/core |
|
👍 |
|
Can you make it >= 2.4 (what Pages currently runs)? Otherwise 👍. Nice implementation. Thanks for the pull request. |
|
@benbalter yup! Once I confirm that the current build works (since I added 2.2 and testing on 3.0 beta -- I don't know if you seen that) I'll drop it to 2.4 and add that to the matrix (unless you want to skip that in the matrix?) |
| @@ -1,9 +1,14 @@ | |||
| language: ruby | |||
| rvm: | |||
| - 2.1 | |||
| - 2.0.0 | |||
| - 2.2 | |||
| - 2.0 | |||
| - 1.9.3 | |||
There was a problem hiding this comment.
Yeah I'm trying to work out the matrix exclude so I can skip this test on 1.9.3.
envygeeks
force-pushed
the
loosen-jekyll-version-requirements
branch
6 times, most recently
from
38e5203
to
cd14f47
Compare
envygeeks
force-pushed
the
loosen-jekyll-version-requirements
branch
from
cd14f47
to
25030ed
Compare
|
I have completed the matrix and figured that beast mode travis-ci configuration out. Now jekyll-feed tests 2.4 - 3.0 on select Ruby versions. This is safe for review and merge when everybody has 👍 |
|
|
|
Nice. Thanks again @envygeeks. 🐢 |
benbalter
added a commit
that referenced
this pull request
Jun 2, 2015
Loosen Jekyll Version Requirements.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we default install jekyll-feed across all our Docker images (master,beta included) and because of the tight coupling that happens on versioning we end up with multiple versions of Jekyll, this loosens that requirement since I don't assume this would break but if it does during this pull I'll gladly fix any problems so it works with both 2.5 and 3.0.