Skip to content

Replaced OpenURI with NET::HTTP and introduced timeout of 3 seconds #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2015
Merged

Replaced OpenURI with NET::HTTP and introduced timeout of 3 seconds #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
135ba35
Replaced OpenURI with NET::HTTP and introduced timeout of 3 seconds
gr4y Aug 7, 2015
fd5b2fd
response body could be nil, so I removed chomp
gr4y Aug 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions lib/jekyll-gist/gist_tag.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
require 'cgi'
require 'open-uri'
require 'net/http'

module Jekyll
module Gist
Expand Down Expand Up @@ -57,13 +57,24 @@ def gist_noscript_tag(gist_id, filename = nil)
end

def fetch_raw_code(gist_id, filename = nil)
url = "https://gist.githubusercontent.com/#{gist_id}/raw"
url = "#{url}/#{filename}" unless filename.empty?
begin
url = "https://gist.githubusercontent.com/#{gist_id}/raw"
url = "#{url}/#{filename}" unless filename.empty?
open(url).read.chomp
uri = URI(url)
Net::HTTP.start(uri.host, uri.port,
use_ssl: uri.scheme == 'https',
read_timeout: 3, open_timeout: 3) do |http|
request = Net::HTTP::Get.new uri
response = http.request(request)
response.body
end
rescue SocketError
nil
rescue OpenURI::HTTPError
rescue Net::HTTPError
nil
rescue Net::OpenTimeout
nil
rescue Net::ReadTimeout
nil
end
end
Expand Down