-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add support for Ruby 1.9.3 #14
Conversation
I will take a look at that when my Mac finished compiling ruby 1.9.3, which might take some more minutes. But I just asked my self if the issue #7 will be un-fixed by fixing #13.
|
So by just removing the So I tried wrapping the begin..rescue..end block into another begin..rescue..end block and catching NameError, which worked out, but results in missing |
Lol a NameError is usually not something you want to catch... If I think I fixed it by just spiking those error classes out. |
@parkr I guessed that catching NameError won't be a smart idea. By the way: I haven't heard the term "spiking out" ever before. Seems I am a little out of the loop when it comes to ruby. Sorry about that. 😭 |
It's absolutely no problem! "Spike out" is an idiom. When I say "Spike out code", I mean "write the initial version". A working scaffold. Sorry for that! I should be more considerate of people who don't speak idiomatic English. |
It's a rather cool way to fix backwards compatibility problems like that one, so I learned something new here. 😄 |
Fixes #13, follow-up to #11.
We need a fix for #7 (comment) that works in Ruby 1.9.3.
/cc @gr4y