Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow noscript fallback to be disabled #29

Merged
merged 4 commits into from
Dec 1, 2015
Merged

Allow noscript fallback to be disabled #29

merged 4 commits into from
Dec 1, 2015

Conversation

benbalter
Copy link
Contributor

Fixes #17.
Fixes #26.

@parkr
Copy link
Member

parkr commented Nov 30, 2015

@benbalter Great! Just needs a test. Thank you!

@parkr parkr added this to the 1.4.0 milestone Nov 30, 2015
@benbalter
Copy link
Contributor Author

Great! Just needs a test

Done (with docs too!)

@parkr
Copy link
Member

parkr commented Nov 30, 2015

LGTM. Once CI gives the 💚, we can merge.

@parkr
Copy link
Member

parkr commented Nov 30, 2015

@benbalter To fix CI, gist must be defined in your block like output.

let(:gist) { "mattr-/24081a1d93d2898ecf0f" } # choose a different ID if you want :)

parkr added a commit that referenced this pull request Dec 1, 2015
@parkr
Merge pull request #29 from jekyll/disable
fb6a4aa 
Merge pull request 29
@parkr parkr merged commit fb6a4aa into master Dec 1, 2015
@parkr parkr deleted the disable branch December 1, 2015 00:08
parkr added a commit that referenced this pull request Dec 1, 2015
@parkr
Update history to reflect merge of #29
acc6063 
[ci skip]
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@benbalter benbalter

Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@benbalter @parkr @jekyllbot