Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Wordpress permalinks #395

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Import Wordpress permalinks #395

merged 2 commits into from
Jan 22, 2019

Conversation

reconbot
Copy link
Contributor

because a good link is forever

@DirtyF DirtyF requested a review from a team January 21, 2019 13:16
ashmaroli
ashmaroli requested changes Jan 21, 2019
View reviewed changes
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some cleaning-up..

lib/jekyll-import/importers/wordpressdotcom.rb Outdated Show resolved Hide resolved
lib/jekyll-import/importers/wordpressdotcom.rb Outdated Show resolved Hide resolved
@reconbot reconbot force-pushed the reconbot/wordpress-permalinks branch 3 times, most recently from 7fcb3dd to 6804597 Compare January 22, 2019 02:20
@ashmaroli
Copy link
Member

@reconbot Thank you for considering my requests. One minor thing left though.
Our linter script has to pass as well.

Please run bash script/fmt -a to fix them.

@reconbot
Import Wordpress permalinks
21b175c 
because a good link is forever
@reconbot reconbot force-pushed the reconbot/wordpress-permalinks branch from 6804597 to 21b175c Compare January 22, 2019 02:58
@reconbot
Copy link
Contributor Author

of course! thanks!

@ashmaroli

This comment has been minimized.

Sign in to view
ashmaroli
ashmaroli approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@reconbot
Copy link
Contributor Author

Looks good to me, thank you my JS was showing =D

@mattr-
Copy link
Member

mattr- commented Jan 22, 2019

@reconbot Thanks so much for your contribution! We appreciate the time you took to add this feature! ❤️

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 6bee0fa into jekyll:master Jan 22, 2019
jekyllbot added a commit that referenced this pull request Jan 22, 2019
@jekyllbot
Update history to reflect merge of #395 [ci skip]
5922ba4
@reconbot
Copy link
Contributor Author

This is literally my favorite part of open source, hacking on your tools to make them better. 🎉

@jekyll jekyll locked and limited conversation to collaborators Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@reconbot @ashmaroli @mattr- @DirtyF @jekyllbot