Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slugify post name with Jekyll::Utils.slugify #410

Merged
merged 1 commit into from
May 2, 2019
Merged

Slugify post name with Jekyll::Utils.slugify #410

merged 1 commit into from
May 2, 2019

Conversation

ashmaroli
Copy link
Member

Delegate to utility function in Core (Jekyll::Utils.slugify understands mode: 'latin' from Jekyll 3.7.0)

@ashmaroli ashmaroli requested a review from a team April 29, 2019 12:59
mattr-
mattr- approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: as long as we already depend on 3.7.0 in the gemspec for the import gem.

@DirtyF
Copy link
Member

DirtyF commented May 2, 2019

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 35e26e8 into jekyll:master May 2, 2019
jekyllbot added a commit that referenced this pull request May 2, 2019
@jekyllbot
Update history to reflect merge of #410 [ci skip]
fb2e897
@ashmaroli ashmaroli deleted the slugify-post-name branch May 2, 2019 05:59
@jekyll jekyll locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattr- mattr- mattr- approved these changes

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashmaroli @DirtyF @mattr- @jekyllbot