Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DotClear importer #414

Merged
merged 4 commits into from
Jun 24, 2019
Merged

DotClear importer #414

merged 4 commits into from
Jun 24, 2019

Conversation

rivsc
Copy link
Contributor

@rivsc rivsc commented Jun 7, 2019

No description provided.

DirtyF
DirtyF previously approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci beaucoup @rivsc 😄

I'll have to trust you on this one, it's been ages since I've touched a dotclear blog.

@DirtyF DirtyF added the feature label Jun 7, 2019
@DirtyF DirtyF requested a review from a team June 7, 2019 21:02
@DirtyF DirtyF dismissed their stale review June 7, 2019 21:03

Tests don't pass

DirtyF
DirtyF requested changes Jun 7, 2019
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, can you run Rubocop to make our script/fmt pass please?

rivsc
rivsc commented Jun 24, 2019
View reviewed changes
Copy link
Contributor Author

@rivsc rivsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ton français est excellent ;p

Some changes for Rubocop. Thanks !

@DirtyF
Copy link
Member

DirtyF commented Jun 24, 2019

Je suis français, ça aide 😄

@DirtyF
Copy link
Member

DirtyF commented Jun 24, 2019

OK, remaining Rubocop offenses are not related to this importer, we'll fix them in anothePR.

@DirtyF DirtyF merged commit 62ef356 into jekyll:master Jun 24, 2019
@rivsc
Copy link
Contributor Author

rivsc commented Jun 24, 2019

Je suis français, ça aide 😄

Oui j'ai vu ^^.

OK, remaining Rubocop offenses are not related to this importer, we'll fix them in anothePR.

Ok, thanks.

@DirtyF
Copy link
Member

DirtyF commented Jun 24, 2019

@rivsc Released in https://github.com/jekyll/jekyll-import/releases/tag/v0.19.0

@jekyll jekyll locked and limited conversation to collaborators Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF requested changes

Assignees
No one assigned
Labels
feature frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rivsc @DirtyF @jekyllbot