Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluxml #430

Merged
merged 5 commits into from
Mar 9, 2020
Merged

Pluxml #430

merged 5 commits into from
Mar 9, 2020

Conversation

Norore
Copy link
Contributor

@Norore Norore commented Mar 9, 2020

PluXML is a blog CMS based on XML files instead of a database for articles and comments.
This script will help people to import their articles and drafts in Jekyll, with Nokogiri library.
I found some troubles with my own articles when you have source code in articles with a format similar to liquid, so I also include an option to tell Jekyll to not use the liquid render in exported files.

Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Norore , we have no PluXML sample data to test this, so I'm gonna trust you on this one.

@DirtyF
Copy link
Member

DirtyF commented Mar 9, 2020

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 4ab4d23 into jekyll:master Mar 9, 2020
jekyllbot added a commit that referenced this pull request Mar 9, 2020
DirtyF added a commit that referenced this pull request Mar 9, 2020
This reverts commit 4ab4d23.
@DirtyF
Copy link
Member

DirtyF commented Mar 9, 2020

Fixed most of Rubocop offenses in b3b328e

JekyllImport::Importers::Pluxml.run({
"source" => "/pluxml/data/articles",
"layout" => "your_layout",
"avoid_liquid" => TRUE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using true here instead of TRUE is recommended, just FYI.

~$ irb
TRUE
>> TRUE
(irb):1: warning: constant ::TRUE is deprecated
=> true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parkr Right, I've changed it to lowercase.

@jekyll jekyll locked and limited conversation to collaborators Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants