-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix erroneous cosmetic changes in Pebble importer #546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One looks right to me but the other needs another look. Thanks for playing along!
@midzer :) the thing is that both forms are 99% equivalent. The gotcha with Ruby compared to Python is that one can have multiple ways to implement the same idea. Therefore, What Parker highlighted in his explanation is that creating the array |
LGTM! @jekyllbot: merge +dev |
midzer: Fix erroneous cosmetic changes in Pebble importer (#546) Merge pull request 546
Thank you @midzer. :) |
(Trying) to fix #545