Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stringify all values coming from site.github #89

Merged
merged 2 commits into from
Dec 11, 2015

Conversation

WasabiFan
Copy link
Contributor

This should convert values to string equivalents when getting them out of site.github. See discussion in jekyll/github-metadata#22 for more information.

@parkr

@parkr
Copy link
Member

parkr commented Dec 11, 2015

This looks fine! To test, please add a test that sets up a non-string in @site.config['github']['url'] and ensures the stringified value is returned. https://github.com/jekyll/jekyll-redirect-from/blob/master/spec/jekyll_redirect_from/redirector_spec.rb

@parkr parkr added the bug label Dec 11, 2015
@WasabiFan
Copy link
Contributor Author

Will-do.

@WasabiFan
Copy link
Contributor Author

I just added that test. I defined a new class to use as the non-string -- if you'd rather I use a different class (instead of defining one) I can.

parkr added a commit that referenced this pull request Dec 11, 2015
@parkr parkr merged commit 838599d into jekyll:master Dec 11, 2015
parkr added a commit that referenced this pull request Dec 11, 2015
@parkr
Copy link
Member

parkr commented Dec 11, 2015

Looks great, thanks, @WasabiFan!

@WasabiFan WasabiFan deleted the stringify-all-github-values branch December 11, 2015 22:10
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants