Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against arrays in subhashes #197

Merged
merged 3 commits into from
Apr 26, 2017
Merged

Guard against arrays in subhashes #197

merged 3 commits into from
Apr 26, 2017

Conversation

benbalter
Copy link
Collaborator

If site.social or page.seo are arrays, strings, or anything other than a Hash, things will 💥 . This PR creates a helper method to safely traverse subhashes, even when they are not actually hashes.

Fixes #196.

Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine

@benbalter benbalter merged commit a0c915f into master Apr 26, 2017
@benbalter benbalter deleted the guard-against-arrays branch April 26, 2017 15:58
@axilleas
Copy link

Thank you! ❤️

@jekyll jekyll locked and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builds failing with "Liquid Exception: no implicit conversion of String into Integer"
4 participants