use canonical_url specified in page if present #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbalter
reviewed
May 24, 2017
lib/jekyll-seo-tag/drop.rb
Outdated
| @@ -183,7 +183,11 @@ def page_lang | |||
|
|
|||
| def canonical_url | |||
| @canonical_url ||= begin | |||
| filters.absolute_url(page["url"]).to_s.gsub(%r!/index\.html$!, "/") | |||
| if page["canonical_url"].present? | |||
There was a problem hiding this comment.
.present? only works in Rails. You'll want to use to_s.empty?
There was a problem hiding this comment.
Didn't know that. Will update this with specified changes.
benbalter
reviewed
May 24, 2017
spec/jekyll_seo_tag/drop_spec.rb
Outdated
| let(:page) { make_page( { "title" => "page title", "canonical_url" => "https://github.com/jekyll/jekyll-seo-tag/"} ) } | ||
| let(:canonical_url) { 'https://github.com/jekyll/jekyll-seo-tag/' } | ||
| it "uses specified canonical url" do | ||
| puts subject.canonical_url |
There was a problem hiding this comment.
Forgot to remove puts, is this proper way to test or I need to create and use posts fixtures? I am not sure about this part 😅
|
@8parth this is great, and thanks for working through our feedback. I made a few minor formatting changes, but think this should be good to merge. Thank you! |
benbalter
approved these changes
May 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assign the canonical url to canonical_url specified by user in page otherwise use default generated url.