Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for image.path causing an invalid url error #228

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Fix for image.path causing an invalid url error #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/jekyll-seo-tag/drop.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ def image
image["path"] ||= image["facebook"] || image["twitter"]
return @image = nil unless image["path"]

unless absolute_url? image["path"]
# absolute_url? will return nil for an invalid URL
if absolute_url?(image["path"]) == false
image["path"] = filters.absolute_url image["path"]
end

Expand Down
2 changes: 1 addition & 1 deletion spec/jekyll_seo_tag/drop_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@
let(:image) { ":" }

it "returns nil" do
expect(subject.image["path"]).to eql("/:")
expect(subject.image["path"]).to eql(":")
end
end

Expand Down