Target Ruby 2.3 and Rubocop 0.56.0 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathawks
reviewed
May 18, 2018
jekyll-seo-tag.gemspec
Outdated
| @@ -30,5 +30,5 @@ Gem::Specification.new do |spec| | |||
| spec.add_development_dependency "bundler", "~> 1.15" | |||
| spec.add_development_dependency "html-proofer", "~> 3.7" | |||
| spec.add_development_dependency "rspec", "~> 3.5" | |||
| spec.add_development_dependency "rubocop", "0.51" | |||
| spec.add_development_dependency "rubocop", "0.56.0" | |||
There was a problem hiding this comment.
Do we want this to be "~> 0.56.0"?
There was a problem hiding this comment.
yes, because Rubocop has a tendency to add new cops that make our tests fail :)
There was a problem hiding this comment.
In patch releases?
Right now, it looks like you've locked it to "0.56.0". Should we change it to "~> 0.56.0" to allow (ie) "0.56.1"?
pathawks
requested changes
May 18, 2018
| @@ -1,6 +1,4 @@ | |||
| rvm: | |||
| - 2.1 | |||
| - 2.2 | |||
There was a problem hiding this comment.
Should we also add spec.required_ruby_version = ">= 2.3.0" to the gemspec?
pathawks
approved these changes
May 18, 2018
|
@jekyllbot: |
+dev
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI may fail as GitHub Pages uses Jekyll 3.7.3 rubocop's config for now, but this has been successfully tested with Jekyll 3.8.1.