Test against Jekyll 4.x #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattr-
approved these changes
Mar 22, 2019
|
The documentation for RuboCop's
I think that's reasonable. |
DirtyF
approved these changes
Mar 22, 2019
|
@jekyllbot: merge +dev |
jekyllbot
added a commit
that referenced
this pull request
Mar 25, 2019
maveille
pushed a commit
to maveille/jekyll-seo-tag
that referenced
this pull request
Aug 3, 2019
Merge pull request 336
maveille
pushed a commit
to maveille/jekyll-seo-tag
that referenced
this pull request
Aug 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming tests pass, this PR will allow the plugin to be used with Jekyll 4.x.
I believe based on the blame, the Pages gem was only required to make local previewing of the documentation easier (but isn't necessary for the plugin itself, tests, etc.