Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Facebook domain verification #455

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

fauno
Copy link
Member

@fauno fauno commented Oct 28, 2021

@ashmaroli
Copy link
Member

I'm on board with the proposal but hesitant nevertheless because this further affects performance.

{% if site.webmaster_verifications %}
  ...
  {% if site.webmaster_verifications.facebook %}
    ...
  {% endif %}
{% endif %}

The above block is evaluated for every page / document of a site using this plugin to return the same result.
We should think of way to optimize this..

@ashmaroli ashmaroli requested a review from a team October 28, 2021 14:03
@fauno
Copy link
Member Author

fauno commented Oct 28, 2021 via email

Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me!

@ashmaroli
Copy link
Member

Thanks @fauno
@jekyllbot; merge +minor

@ashmaroli
Copy link
Member

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 062604e into jekyll:master Oct 28, 2021
jekyllbot added a commit that referenced this pull request Oct 28, 2021
@jekyll jekyll locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants