Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404.html appearing in sitemap.xml #113

Closed
henrywright opened this issue May 4, 2016 · 8 comments · Fixed by #164
Closed

404.html appearing in sitemap.xml #113

henrywright opened this issue May 4, 2016 · 8 comments · Fixed by #164

Comments

@henrywright
Copy link

henrywright commented May 4, 2016

I have a 404.html file in my root. When I view the contents of sitemap.xml, I see:

...
<url>
<loc>https://example.com/404.html</loc>
</url>
...

Should this page be excluded from the sitemap?

@iloveip
Copy link

iloveip commented May 5, 2016

@henrywright You can add sitemap: false in the front matter of the file to exclude unwanted pages from the sitemap manually.

@henrywright
Copy link
Author

Thanks for the info.

@benbalter
Copy link
Contributor

I can't imagine a case where you'd want the 404 in the sitemap... I'm thinking this should be excluded by default.

@benbalter benbalter reopened this Dec 13, 2016
benbalter added a commit to benbalter/kubernetes.github.io that referenced this issue Dec 13, 2016
@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@ghost
Copy link

ghost commented Jan 24, 2017

@jekyllbot info

@jekyllbot jekyllbot removed the stale label Jan 24, 2017
@jekyllbot
Copy link
Contributor

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@benbalter
Copy link
Contributor

Any objection to auto-excluding where page.url == '/404.html'? If so, is anyone interested in creating a pull request to implement this?

@jekyllbot jekyllbot removed the stale label Mar 24, 2017
@ghost
Copy link

ghost commented Mar 24, 2017

@benbalter #164

@jekyll jekyll locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants