Fixes #80, #106. Make the hamburger work with pure CSS. #111
Conversation
alxn
changed the title
| float: right; | ||
| width: 36px; | ||
| height: 36px; | ||
| z-index: 2; |
There was a problem hiding this comment.
perhaps also add cursor: pointer; here?
There was a problem hiding this comment.
@Ambrosiani I'd wondered about that, but it'll only make sense if the hamburger gets used for desktop. cursor: pointer; doesn't seem to make much sense for me if it's in "touch" ?
There was a problem hiding this comment.
The hamburger menu appears in thin desktop windows as well. But perhaps it shouldn't be put here – I don't know how the SCSS media queries work.
There was a problem hiding this comment.
@Ambrosiani are you're right, I'll add it in.
There was a problem hiding this comment.
@Ambrosiani you should see it updated on my gh-pages site as well.
|
Works for me on iOS 10.2.1 on an iPhone 6 |
|
Is it going to be merged? |
|
@gatezh that's up to the maintainers. |
|
/cc: @jekyll/minima |
|
Minima hasn't seen a merge in months now.. Mantainers, some ❤️ please. |
|
@ashmaroli Aren't you a maintainer? Who's in charge here? |
No, I don't have write-permissions here. I'm guessing @parkr and @benbalter is in charge of this repo |
|
Is there consensus here that this should get merged? If so, please submit a code review and I can get this merged. Also, if anyone is interested in becoming a maintainer of this project, please feel free to jump in and triage the existing open PRs (what can be merged, what should be closed, etc.) and we can go from there. |
|
Wow @alxn! This is great. Thanks for the full request and for contributing to Jekyll! @jekyllbot: merge +minor. |
…ekyll#111) Merge pull request 111
|
Guys, I must not be in the right head space or something. Am i just supposed to move the z-index of my toggle up? Here is my portfolio kurkweb.github.io . Side note, safari doesn't seem to like bootstrap css or jquery. I have seen other websites for people I am looking to hire me have slider issues on safari and hamburger issues as well. Pshh |
…ekyll#111) Merge pull request 111
I've been reading up on this, while there seems to be a movement against hamburgers, there's plenty of examples of pure-CSS ones: 1, 2. - I think these are all using a
<input>for the clickable.This PR adds that support, and I've put up a gh-pages site at https://alxn.github.io/minima/, it would be great if everyone could test that site and let me know in the comments how it works for them, which OS/Browser they were using, and I can update the below:
So far tested: