Corrects image aspect ratio #575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Edits** `_sass/minima/_base.scss`
Setting CSS of `max-width: 100%;` may be combined with `height: auto;`
which causes image height to shrink if view-port is less than image width.
Note, this may require that image HTML attributes for height
and width be defined, eg...
```html
<img alt-text="Place holder image of a cat"
width="700"
height="500"
src="https://placekitten.com/700/500" />
```
mattr-
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edits
_sass/minima/_base.scssSetting CSS of
max-width: 100%;may be combined withheight: auto;which causes image height to shrink if view-port is less than image width.
Note, this may require that image HTML attributes for height
and width be defined, eg...