Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automation] Update ex_doc to 0.31.2 #84

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 6, 2024

This is an automated action to update ex_doc to version 0.31.2

@paulo-ferraz-oliveira
Copy link
Collaborator

@starbelly, could you try (on top of this pr), for the checkout action (in up_ex_doc_version.yml), to do

      - uses: actions/checkout@v4
        with:
          token: ${{${{ secrets.GITHUB_TOKEN }}}}

My expectation is that the checks run after that, since there's some sort of authentication from GitHub.

@starbelly
Copy link
Collaborator

@starbelly, could you try (on top of this pr), for the checkout action (in up_ex_doc_version.yml), to do

      - uses: actions/checkout@v4
        with:
          token: ${{${{ secrets.GITHUB_TOKEN }}}}

My expectation is that the checks run after that, since there's some sort of authentication from GitHub.

Sorry, not following.

@paulo-ferraz-oliveira
Copy link
Collaborator

paulo-ferraz-oliveira commented Mar 7, 2024

There's an error in my input example, but

      - uses: actions/checkout@v4
        with:
          token: ${{secrets.GITHUB_TOKEN}}

at https://github.com/starbelly/rebar3_ex_doc/blob/main/.github/workflows/up_ex_doc_version.yml#L25 should make CI run for this type of pull request (ref: https://docs.github.com/en/actions/security-guides/automatic-token-authentication). I'll test my hypothesis in my fork of this.

Edit: if it works I'll try to summarise my understanding of this, which I didn't previously.

@paulo-ferraz-oliveira
Copy link
Collaborator

paulo-ferraz-oliveira commented Mar 7, 2024

Hm...

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run.

😢 I think I'd read this before, and tried stuff to go around it. It still makes little sense this is not available as a feature.

Edit: I'll propose a different solution to this issue. Feel free to merge and close, if you see fit.

@starbelly
Copy link
Collaborator

I'll go ahead and merge it since I want us to be up to date, such that I can cut a release today.

@starbelly starbelly merged commit 1423252 into main Mar 8, 2024
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the up_ex_doc_to_0.31.2 branch March 8, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants