Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Add instructions to run jellyfin from source #66

Merged
merged 1 commit into from
Apr 13, 2019
Merged

Add instructions to run jellyfin from source #66

merged 1 commit into from
Apr 13, 2019

Conversation

DrPandemic
Copy link
Contributor

I'm not used to dotnet core so it took me some time to understand how to run it after building it from source.

Adds an instruction to the list to run it.

@@ -31,6 +31,9 @@ All package builds begin with the first two steps:
`./build --list-platforms`
`./build <platform> all`

4. Run the executable:
`./Jellyfin.Server/bin/Release/netcoreapp<dotnetcore-version>/<platform>/jellyfin`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think the build scripts output to a specific directory, but I'm not sure which one. If this is the case we should update to the proper directory, otherwise this is fine. @joshuaboniface might know.

@joshuaboniface
Copy link
Member

Please note that those sets of trailing double spaces are for formatting and are required.

@dkanada is also correct; on completion of the scripts no binaries are present at that location - they get zipped up and then cleaned. The step should indeed reference where the resulring zip/tar archive is, then reference the (to be written) installation docs for the standalone binary packages.

@DrPandemic
Copy link
Contributor Author

DrPandemic commented Apr 10, 2019

Perfect, it seems that this PR don't align with what you are trying to do. I'll close it if it's the case.

In this case, maybe a page to use debug builds could be useful, what do you think? Also, normally, how do you run you dev builds?

@DrPandemic
Copy link
Contributor Author

DrPandemic commented Apr 11, 2019

Ok I just understood why I was confused about the packaging. The help from ./build says that the output is going to be in ../jellyfin-build/<platform> but it's actually in ../bin/<platform>. Since the build script shouldn't produce executables, this PR only mentions where the final archive is going to be. I'll also do a quick PR on the build script to update the help message.

I think it could also be useful to add doc to know how to build and run debug builds. I would like writing it, but I'm not familiar enough with the dotnet core development process. Do you have pointers on how you are doing it?

@anthonylavado
Copy link
Member

AFAIK - the debut builds are useful if you are going to be debugging them with a code editor, but there’s no other benefit to doing so. That’s the only difference between “debug” and “release” builds.

@joshuaboniface joshuaboniface merged commit 5683883 into jellyfin-archive:master Apr 13, 2019
@DrPandemic DrPandemic deleted the run-instruction branch April 14, 2019 02:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants