This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Change windows build title/powershell command/slashes #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated windows build script title for consistency. Added explicit powershell command to step 4 in windows build steps. Changed slashes to match windows directory scheme in step 5.
LogicalPhallacy
approved these changes
Jul 24, 2019
|
|
||
| 5. Run the Jellyfin build script: | ||
| `deployment/windows/build-jellyfin.ps1 -verbose` | ||
| `deployment\windows\build-jellyfin.ps1 -verbose` |
There was a problem hiding this comment.
Forward slashes and back slashes are irrelevant in powershell. This can be changed, but it makes little difference and the script has all refs in forward slashes for powershell core compat
There was a problem hiding this comment.
The change was mostly for consistency within the windows section. Backslashes are in the section for pathing and I wanted to make it consistent for the reader.
oddstr13
approved these changes
Jul 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated windows build script title for consistency.
Added explicit powershell command to step 4 in windows
build steps.
Changed slashes to match windows directory scheme in
step 5.