-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emby 2.2.9 backport plus Jellification #7
base: master
Are you sure you want to change the base?
Conversation
ShaheedHaque
commented
Jul 3, 2021
•
edited
Loading
edited
- Get updated Jellyfin images etc from https://github.com/computersandstuff/jellyfin-samsungtv-updated.
- Backport Emby2.2.9 application code.
- Add installation notes and a helper script.
The splash screen, in app logos, and launch icon logos have been changed to Jellyfin's logo which was taken directly from the img folder from Jellyfin web. The user accounts icon and rotten tomatos ratings have been updated as well as the player controls and slider being changed to the Jellyfin purple insdead of the emby green. The name of the app was changed to Jellyfin in various locations except for the credit page as I thought it better to leave the names of the original contributers and emby's website. No major code was changed and I understand that this is an old app for older samsung TVs (like my own), but I as I am still learning C# I wanted to start contributing in a much smaller area like this one.
Do you have an older Samsung TV or something? Most of our Samsung work is on the new Tizen repo and we don't plan on supporting this client in the future. |
Yes, I do. I'm not overly concerned that you guys should spend time on this, at least part of my thinking is that anyone else that cares will see this PR and may instead just pull the code from my fork. But if it is merged, then I may continue to play around with the code... On a similar basis... |
Since it's supposedly impossible to release new apps on Orsay TVs we probably wont be merging anything here. If you did want to maintain a client you're welcome to add it to our docs in the list of available clients though. |
IIUC this repo is for users who want to install the app via a local web server (or maybe USB) since the Samsung "app store" is not longer hosting new content. So I'm not sure I understand why that might influence the decision to merge? [Though as I said before, I'm OK with not merging if that is deemed the right way forward]. |
Thanks for your effort @ShaheedHaque , i'm using your fork and works fine :), lets save the world reusing our old tvs till they die! |
@ShaheedHaque doing the lords work here 😄 thanks, working 2.2.9 on a ES5500 from 2012 |
I recently had network issue with the latests versions of the Jellyfin server (10.10+) I installed it and guess what? it works out of the box ! So this is my advice: on old Samsung Orsay models, just use Emby client if available on the official store. |