Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tvOS - Show and interact with the video menu #1066

Merged
merged 6 commits into from
Sep 5, 2024
Merged

tvOS - Show and interact with the video menu #1066

merged 6 commits into from
Sep 5, 2024

Conversation

MatsMoll
Copy link
Contributor

Made it possible to use the Siri remote to play / stop the video.
This also shows the video menu. Therefore, making it possible to set subtitles etc.

The PreferencesView was also removed when showing the VideoPlayer as it added some unwanted padding to the video content.

LePips
LePips requested changes May 24, 2024
View reviewed changes
Shared/Coordinators/VideoPlayerCoordinator.swift Show resolved Hide resolved
Swiftfin tvOS/Views/VideoPlayer/VideoPlayer.swift Outdated Show resolved Hide resolved
Swiftfin tvOS/Views/VideoPlayer/VideoPlayer.swift Outdated Show resolved Hide resolved
Swiftfin tvOS/Views/VideoPlayer/Overlays/Overlay.swift Outdated Show resolved Hide resolved
Swiftfin tvOS/Views/VideoPlayer/VideoPlayer.swift Outdated Show resolved Hide resolved
@MatsMoll
Copy link
Contributor Author

Thanks for the reference, it helped me implement an alternative version.
I have not added support for swipe recognition, but it is a start at least

LePips
LePips requested changes May 26, 2024
View reviewed changes
Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. However, let's only make press changes available on tvOS for now and make available to other platforms if applicable.

PreferencesView/Sources/PreferencesView/PressCommandAction.swift Outdated Show resolved Hide resolved
PreferencesView/Sources/PreferencesView/PreferencesView.swift Outdated Show resolved Hide resolved
PreferencesView/Sources/PreferencesView/PressCommandBuilder.swift Show resolved Hide resolved
PreferencesView/Sources/PreferencesView/UIPreferencesHostingController.swift Show resolved Hide resolved
PreferencesView/Sources/PreferencesView/UIPreferencesHostingController.swift Outdated Show resolved Hide resolved
PreferencesView/Sources/PreferencesView/ViewExtensions.swift Outdated Show resolved Hide resolved
@LePips LePips mentioned this pull request May 26, 2024
Closed
@LePips LePips linked an issue May 31, 2024 that may be closed by this pull request
[tvOS] videoPlayer view incorrect #1082
Closed
LePips
LePips approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will be running up against this in #1203 soon and have addressed my comments.

@LePips LePips enabled auto-merge (squash) September 5, 2024 19:41
@LePips LePips merged commit 081a316 into jellyfin:main Sep 5, 2024
4 checks passed
@MatsMoll
Copy link
Contributor Author

MatsMoll commented Sep 9, 2024

Thanks for completing it @LePips! I completely forgot about it, as I focused on some other projects

@MatsMoll MatsMoll deleted the matsei/video-bug branch September 11, 2024 13:02
@LePips LePips added the bug Something isn't working label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LePips LePips LePips approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tvOS] videoPlayer view incorrect
2 participants
@MatsMoll @LePips