[tvOS] TV Shows Icon Doesn't Highlight #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force TV Show Icon to render in Monochrome to fix active highlighting weirdness.
I think...?
It's one line, why am I struggling with this?
LePips
requested changes
May 27, 2024
Shared/Coordinators/MainCoordinator/tvOSMainTabCoordinator.swift
Outdated
Show resolved
Hide resolved
|
@LePips Comment Removed and Linting resolved! |
LePips
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #1073
Force TV Show Icon to render in Monochrome to fix active highlighting weirdness. The other alternative I considered when setting all Icons for the Tabs to be .fill that resolves this too. The issue seems to only exist in the tv icon. Could be a tvOS version issue?
Might be worth leaving a todo to look at this as we start targeting a newer tvOS version?
TV Shows (Current)
Unselected:
Selected:
TV Shows (This PR)
Unselected:
**Selected:
