Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup video player settings #1084

Merged
merged 12 commits into from
Jun 9, 2024
Merged

Cleanup video player settings #1084

merged 12 commits into from
Jun 9, 2024

Conversation

chickdan
Copy link
Contributor

@chickdan chickdan commented Jun 6, 2024 •
edited
Loading

Completes the organization TODO of the VideoPlayerSettingsView plus two other small items.

@LePips
Copy link
Member

LePips commented Jun 8, 2024

Cool cool cool, thanks for doing some housekeeping.

I'll be able to take a look at this soon.

LePips
LePips requested changes Jun 8, 2024
View reviewed changes
Copy link
Member

@LePips LePips left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some other organization stuff.

Swiftfin/Views/ConnectToServerView.swift Outdated Show resolved Hide resolved
Swiftfin.xcodeproj/project.pbxproj Show resolved Hide resolved
@LePips LePips mentioned this pull request Jun 8, 2024
Merged
@LePips LePips merged commit 3128a78 into jellyfin:main Jun 9, 2024
4 checks passed
@chickdan chickdan deleted the cleanup_video_player_settings branch September 25, 2024 02:01
@LePips LePips added enhancement New feature or request developer Developer facing issues labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LePips LePips LePips approved these changes

Assignees
No one assigned
Labels
developer Developer facing issues enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chickdan @LePips