Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Admin Dashboard - Users Management (Passwords) #1278

Closed
wants to merge 8 commits into from

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Oct 17, 2024

I wanted to try and make this one a smaller one but it's still coming in at like 800 lines. Luckily, the majority of this work is the ViewModel, Observer, and I almost 100% copy/pasted the ResetUserPasswordView so that one should be familiar with my only addition being a Reset Password button.

This creates a view with all of the users on the Jellyfin Server. It says their name, shows their icon, and has the last time they were seen. This is ordered alphabetically.

Selecting a user takes you to a UserDetailsView. This view WILL contain more items:

  1. Profile
  2. Permissions (Done, but this is a bigger PR so I wanted to split it up)
  3. Access
  4. Parental Controls
  5. Devices (This is honestly a single line of code once [iOS] Admin Dashboard - Device Management #1277 is merged)

Currently, only the PasswordView is done. This is a direct steal of ResetUserPasswordView but uses my observer's actions instead. This Observer is Eventful so I am capturing a success/failure message depending on the response. The reset password is the only addition to ResetUserPasswordView.

Localizations are missing from this PR. Primarily because, if I localize everything then #1277 gets merged, I have to do a whole thing to update it to this branch. Instead, I am just going to localize everything either once #1277 is done OR, if this branch does in first, I have a branch where I have the User Permissions almost done that I can add the localizations to.

Views

It's out of order... But UsersView | Password | UserDetailsView
Screenshot 2024-10-16 at 22 38 17

@JPKribs JPKribs changed the title [iOS] Admin Dashboard - UsersView v1 + Passwords [iOS] Admin Dashboard - Users Management (Passwords) Oct 17, 2024
@JPKribs JPKribs marked this pull request as draft October 18, 2024 03:01
@JPKribs
Copy link
Member Author

JPKribs commented Oct 18, 2024

Putting on hold for a sec while waiting on #1277

@JPKribs
Copy link
Member Author

JPKribs commented Oct 23, 2024

Closing in favor of: #1287.

Passwords will come in their own PR since I'm trying to avoid creating weird bulk PRs and keep things single-focused.

@JPKribs JPKribs closed this Oct 23, 2024
@JPKribs JPKribs deleted the adminDashboardUsersV1 branch October 24, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant