Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Media Item Menu | Edit Metadata #1323

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Nov 21, 2024

Summary

Adds a section to the ItemEditorView to allow for manually changing most metadata. This does not include free-form content such as:

  • Studios
  • Genres
  • People
  • Tags

These will be added in a later PR to keep this from getting too large. These will require an editView & addView to allow deleting existing items or adding a new item to them. To simplify review, these can be seen here but I'll add these as a separate component when ready.

Screenshots

New Button New Button
View pt. 1 View pt. 1
View pt. 2 View pt. 2
View pt. 3 View pt. 3

@JPKribs
Copy link
Member Author

JPKribs commented Nov 21, 2024

This is still coming in a little bigger than I would like it to but a lot of the line count is coming from the enums/extensions that are more volume than substance. I'm leaving this in draft for a sec because I'm under the weather this week and want to review this more in depth with a clear head. Primarily I want to look at:

  1. Should Metadata & Lock Metadata Sections be two separate views?
  2. Does splitting the Pickers into their own files make sense? It makes sense for Language since I can see use reusing that for something like 'Default subtitles' or a feature like that later but I doubt Country will get much use. Finally, I would be amazed if 3DVideoFormatPicker ever gets usages outside this PR.
  3. Does the order of the sections/buttons make sense?
  4. Is the current switch case for EditMetadataView the best way to do this between ItemTypes or is there a better way to be doing this?

@JPKribs JPKribs changed the title [WIP] [iOS] Media Item Menu | Edit Metadata Pt. 1 [WIP] [iOS] Media Item Menu | Edit Metadata Nov 22, 2024
@JPKribs JPKribs marked this pull request as ready for review November 24, 2024 03:01
@JPKribs JPKribs changed the title [WIP] [iOS] Media Item Menu | Edit Metadata [iOS] Media Item Menu | Edit Metadata Nov 24, 2024
@JPKribs JPKribs added enhancement New feature or request and removed enhancement New feature or request labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants