Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Toggles [iOS] [iPadOS] #847

Merged
merged 11 commits into from
Sep 20, 2023
Merged

Filter Toggles [iOS] [iPadOS] #847

merged 11 commits into from
Sep 20, 2023

Commits on Sep 16, 2023

  1. Create Filter Toggles

    Settings in the Customization menu to enable/disable Library Filters.
    JPKribs authored Sep 16, 2023
    Configuration menu
    Copy the full SHA
    ae4743a View commit details
    Browse the repository at this point in the history
  2. Filter Toggle Defaults

    Set all Filter Defaults to True.
    JPKribs authored Sep 16, 2023
    Configuration menu
    Copy the full SHA
    f037178 View commit details
    Browse the repository at this point in the history
  3. Enable/Disable Filters

    From the Customization > Filters option, enable or disable a filter.
    JPKribs authored Sep 16, 2023
    Configuration menu
    Copy the full SHA
    f898b77 View commit details
    Browse the repository at this point in the history
  4. Fully remove the HStack containing the Filter Pills if ALL of the fil…

    …ters are disabled. If one or more filters are enabled, show the HStack.
    Joe Kribs committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    225fba8 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Updated to add/remove filters as an array instead of individual boole…

    …ans. Since this is now an array, this allows re-ordering the filters. FilterDrawerHStack will now be populated by a ForEach building the HStack from the items enabled in the Array. Created a second, possibly unnecessary function on the FilterDrawerHStack that finds the property value for the ItemsFilter to identify which filters should be highlighted as active and which are inactive.
    Joe Kribs committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    93fb889 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Removed the reflection in place of a much cleaner func on the enum it…

    …self. All edits for filters are still done on the enum itself. Alphabetized the FilterDrawer entry in the SettingssCoordinator. I *think* changed the SettingsCoordinator to submit from the project folder and not from my documents. Turned off the filter drawer from the library/search view instead of returning and empty filterdrawer.
    Joe Kribs committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    bba9ea8 View commit details
    Browse the repository at this point in the history
  2. Created Library vs Search settings. Broke Filters out into its own se…

    …ction in customization. Created a FilterDrawerType Enum for Library vs Search filters. Allows for expansion later. Changed logic for the LibrarySearch Views to point to the correct HStack Filter Drawer.
    Joe Kribs committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    98e03d3 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Updated the FilterDrawerButton name to FilterDrawerSelection to avoid…

    … duplicate Class Names. Removed the FilterDrawerTypes by instead just passing the Default.Filters.Search/Library from the respective Search/LibraryView. Updated all of the reference points with the name names. Re-added the default FilterDrawerSelection Defaults for usage in determining if the button should be active. Updated the Search/LibraryView to ACTUALLY drop the NavBarDrawer if unused instead of returning an empty bar.
    Joe Kribs committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    0dfb1e3 View commit details
    Browse the repository at this point in the history
  2. Linting Changes

    Joe Kribs committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    81ae8ef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    670ff5b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Linting fixes. Unsure if this resolves "Wrap Lines that exceed specif…

    …ied maximum width." Resolves tvOS Build errors.
    Joe Kribs committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1111482 View commit details
    Browse the repository at this point in the history